Btrie disable flag #33457
Merged
Btrie disable flag #33457
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java
extensions
runners
dataflow
direct
core
jet
portability
labels
|
R: @robertwb |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33457 +/- ##
============================================
- Coverage 59.08% 59.08% -0.01%
+ Complexity 3239 3237 -2
============================================
Files 1156 1156
Lines 176919 176907 -12
Branches 3391 3391
============================================
- Hits 104541 104532 -9
+ Misses 69011 69008 -3
Partials 3367 3367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rohitsinha54
force-pushed
the
btrie-disable-flag
branch
from
46ff528 to
3b66eca
Compare
3 tasks
rohitsinha54
force-pushed
the
btrie-disable-flag
branch
from
3b66eca to
80a6938
Compare
github-actions
bot
removed
extensions
runners
dataflow
direct
core
jet
portability
labels
|
@robertwb Please take a look. Thanks. |
rohitsinha54
force-pushed
the
btrie-disable-flag
branch
from
80a6938 to
5aae10d
Compare
|
The two failure are unrelated to this change. |
robertwb
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to disable user bounded trie.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.